Re: [TCLCORE] switch USE_PANIC_ON_PHOTO_ALLOC_FAILURE

fossil annotate is a very powerful command to determine the origin of 
things.


In this specific case:


     https://core.tcl.tk/tk/info/1839ce25d99a4ffe


So I'd say this is a mistake in the above commit which:


   - added Tk_PhotoSetSize_Panic with 3 args

   - changed the signature of Tk_PhotoSetSize by adding the 'interp' arg 
to it

   - forgot to update signature of Tk_PhotoSetSize_Panic accordingly


Other opinions, someone? The original author perhaps (I'm prone to 
errors, so...)?


Regards,

F.



Le 20/02/2018 à 17:49, Zaumseil René a écrit :
>> Hello,>>> The function Tk_PhotoSetSize() has 4 paramaters.>> The function Tk_PhotoSetSize_Panic() has 3 Parameters.>>> In tk.h at line #1590 is the following code:>>> #ifdef USE_PANIC_ON_PHOTO_ALLOC_FAILURE> #   ifdef Tk_PhotoExpand> # undef Tk_PhotoExpand> #   endif> #   define Tk_PhotoExpand  Tk_PhotoExpand_Panic> #   ifdef Tk_PhotoSetSize> # undef Tk_PhotoSetSize> #   endif> #   define Tk_PhotoSetSize  Tk_PhotoSetSize_Panic> #endif /* USE_PANIC_ON_PHOTO_ALLOC_FAILURE */>>> When I use Tk_PhotoSetSize() in an extension I have to check > for USE_PANIC_ON_PHOTO_ALLOC_FAILURE.>>> Is this intended behaviour?>>>> Thank you>> René>>> Kernkraftwerk Goesgen-Daeniken AG> CH-4658 Daeniken, Switzerland>> Diese Nachricht (inkl. Anhaenge) beinhaltet moeglicherweise > vertrauliche oder gesetzlich geschuetzte Daten oder Informationen. Zum > Empfang derselben ist (sind) ausschliesslich die genannte(n) > Person(en) bestimmt. Falls Sie diese Nachricht irrtuemlicherweise > erreicht hat, sind Sie hoeflich gebeten, diese unter Ausschluss jeder > Reproduktion zu vernichten und den Absender umgehend zu > benachrichtigen. Besten Dank.>>>> ------------------------------------------------------------------------------> Check out the vibrant tech community on one of the world's most> engaging tech sites, Slashdot.org! http://sdm.link/slashdot>>> _______________________________________________> Tcl-Core mailing list> Tcl-...@lists.sourceforge.net> https://lists.sourceforge.net/lists/listinfo/tcl-core

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot