| Store | Cart

Re: [TCLCORE] [flightaware/Tcl-bounties] Intent to work on speedups to `clock format` and `clock scan` (#4)

From: Kevin Kenny <kken...@nycap.rr.com>
Fri, 7 Apr 2017 22:46:07 -0400
Copying tcl-core on this as well:


On 04/07/2017 02:25 PM, Serg G. Brester wrote:
>> Thanks for the reminder (just too many tasks)!> Nop, I think, we don't need a TIP as long as it is not realy an > enhancement (besides the little incompatibilities, which belong rather > to bug fixing resp. some artifical cases).> I hoped for some feadback from TCT (or/and from flightaware;), but > excepting pair colleagues I got nothing up to now from there.> Inbetween I had found a small "bug" there, that is already fixed (must > be rebased in fossil).> And I've tested it on some systems of me using tcl (where it looks > very good all the time).>> So I'll try to make a back-porting to 8.6 the next week (should be > relative easy, because I almost alone dare to change there > something;), and then to start CFV survey for ca. two weeks for both > 8.6 and trunk branches (I hope one or the other is accepted, or I'm > listening some agruments against, that I can then "fix").>> —> You are receiving this because you were mentioned.> Reply to this email directly, view it on GitHub > <https://github.com/flightaware/Tcl-bounties/issues/4#issuecomment-292614764>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AANPUYJBdJqeY1VEu2mWggcT8p49fvzrks5rtn-PgaJpZM4K2cWi>.>
I don't recall ever getting answers to several questions that I asked. 
It could be that there were technological issues that kept us from 
making contact.

(1) Are you willing to maintain the code moving forward? (If not, I need 
more time to review. Things have been very busy for the last few months, 
and I've not had time to source-dive in your separate branches.

(2) What, if any, existing test cases needed to be modified to support 
your performance improvements, and why? (If they were there simply for 
'bugward compatibility', that's an acceptable answer. I recognize that 
some of the Tcl test cases have historically not been tests, but rather 
experiments.

(3) Does the code continue to support multilocalization (having places 
in the same process or in the same interpreter where different time 
zones or locales are in use)?

(4) Is the claimed speedup achievable without also addressing the msgcat 
subsystem, or were speedups there also in scope?

(5) Is the new code still self-contained, or does it rely on third-party 
libraries that are subject to licensing that must be reviewed?

(6) Has the new code been run with the test suite under a profiler such 
as gcov (or nagelfar for any portions that are still written in Tcl)? 
What fraction of the code remains uncovered?


If all of these questions have acceptable answers, then I don't think 
there's any need for a vote. I speak both as a TCTer and as the 
maintainer of record for [clock]. We just need to get you commit access 
for (1) - I can do that if you agree - and then get everything merged 
in. I presume documentation changes should be minimal, just the new %Es 
plus documenting any other new functionality needed. If it's a drop-in 
replacement that passes the test suite, I don't have a problem with it 
appearing in a point release.

If you haven't merged recently, you'll also find that I added ensemble 
compilation for [clock] (and for [encoding] which was also missing it). 
In addition, I added bytecoding for [clock 
seconds/millis/micros/clicks], which should be an additional little 
boost. I just dropped those into core-8-6-branch as well as trunk, and 
nobody objected.


Thanks for taking this on! I'd been meaning to do the rewrite in C 
(which for me would have been relatively straightforward but 
time-consuming) for years, but always had other fish to fry. Doing the 
initial implementation in C would have got me horribly bogged down, so I 
still think that proving the concept in Tcl first was a good idea, but 
somehow, the Tcl implementation always remained Almost Good Enough and 
the performance hacking never got enough attention.

-- 73 de ke9tv/2, Kevin


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Tcl-Core mailing list
Tcl-...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/tcl-core
Recent Messages in this Thread
Martin Lemburg Jun 02, 2017 02:09 pm
Jan Nijtmans Jun 02, 2017 02:36 pm
Harald Oehlmann Jun 02, 2017 01:07 pm
Martin Lemburg Jun 02, 2017 02:39 pm
Dipl. Ing. Sergey G. Brester Jun 02, 2017 03:29 pm
Kevin Kenny Jun 02, 2017 04:48 pm
Donald G Porter Jun 05, 2017 04:57 pm
Dipl. Ing. Sergey G. Brester via Tcl-Core Jun 21, 2017 02:13 pm
Jan Nijtmans Jun 07, 2017 09:51 am
Jan Nijtmans Jun 02, 2017 12:57 pm
Christian Gollwitzer Jun 02, 2017 12:46 pm
Harald Oehlmann Jun 02, 2017 09:21 am
Christian Gollwitzer Jun 02, 2017 06:51 am
Kevin Kenny Jun 01, 2017 05:37 pm
Dipl. Ing. Sergey G. Brester Jun 01, 2017 07:14 pm
Dipl. Ing. Sergey G. Brester Jun 02, 2017 08:09 am
Jan Nijtmans Jun 02, 2017 09:59 am
Donald Porter Jun 02, 2017 12:23 pm
Kevin Kenny Apr 08, 2017 02:46 am
Dipl. Ing. Sergey G. Brester Apr 10, 2017 10:58 am
Kevin Kenny Apr 10, 2017 06:20 pm
Dipl. Ing. Sergey G. Brester Apr 10, 2017 07:20 pm
Dipl. Ing. Sergey G. Brester May 12, 2017 11:45 am
Harald Oehlmann May 12, 2017 12:23 pm
Donald G Porter May 15, 2017 06:11 pm
Dipl. Ing. Sergey G. Brester May 15, 2017 06:21 pm
Dipl. Ing. Sergey G. Brester May 15, 2017 07:01 pm
Donal K. Fellows May 16, 2017 11:54 am
Dipl. Ing. Sergey G. Brester May 29, 2017 11:46 am
Jan Nijtmans May 30, 2017 08:30 am
Harald Oehlmann May 30, 2017 08:51 am
Harald Oehlmann May 30, 2017 10:15 am
Dipl. Ing. Sergey G. Brester May 30, 2017 11:50 am
Dipl. Ing. Sergey G. Brester May 30, 2017 04:55 pm
Jan Nijtmans May 31, 2017 09:31 am
Dipl. Ing. Sergey G. Brester May 31, 2017 10:48 am
Jan Nijtmans May 31, 2017 11:56 am
Jan Nijtmans Jun 01, 2017 09:18 am
Dipl. Ing. Sergey G. Brester Jun 01, 2017 10:00 am
Dipl. Ing. Sergey G. Brester Jun 01, 2017 11:37 am
Donald G Porter Jun 01, 2017 02:13 pm
Jan Nijtmans Jun 01, 2017 02:44 pm
Christian Gollwitzer Jun 02, 2017 06:43 am
Christian Gollwitzer Jun 02, 2017 06:47 am
Dipl. Ing. Sergey G. Brester Jun 02, 2017 06:55 am
Dipl. Ing. Sergey G. Brester Jun 02, 2017 10:50 pm
Dipl. Ing. Sergey G. Brester via Tcl-Core Jun 07, 2017 09:06 am
Donal K. Fellows Jun 01, 2017 02:21 pm
Kevin Kenny Jun 01, 2017 05:25 pm
Dipl. Ing. Sergey Brester May 30, 2017 09:07 am
Dipl. Ing. Sergey G. Brester May 30, 2017 09:08 am
Dipl. Ing. Sergey G. Brester May 31, 2017 08:50 am
Dipl. Ing. Sergey G. Brester May 31, 2017 09:31 am
Jan Nijtmans May 31, 2017 09:34 am
Jan Nijtmans May 31, 2017 09:57 am
Dipl. Ing. Sergey G. Brester May 31, 2017 10:59 am
Messages in this thread