Re: [TCLCORE] TIP #457: Add Support for Named Arguments (rev 1.5)

> On Jan 16, 2017, at 2:32 PM, Mathieu Lafon <mla...@gmail.com> wrote:> > Hello Tcl-core,> > I haven't received any replies on my last message but that was> probably not the best moment of the year to seek for feedback.

That's true.

> > The implementation of my proposal is finished, so I'm open to any> comments/feedback/criticism on the proposal or on the code. The code> is currently on GitHub but I can put it on a fossil branch if required> and given a write-access account.

I don't have the time to review or run the code.  
I noticed one typo in the TIP, see "wich" here:
Modification in how proc are defined
Tcl-pure procedures can be defined in a way wich state that the procedure will automaticaly handle -option value arguments.

Some points on reviewing the TIP:
   * The proposal is straight forward so I wouldn't imagine the implementation to be overly complicated.  
   * It seems somewhat limited to have this feature only apply to proc's without a corresponding extension to the C API for providing the same compatibility for non-proc commands.  Users of [call] may find it confusing to have it work with some commands and not others since it's not immediately obvious which commands are implement as procs and which are implemented in C.
   * It should be made clear that [call] is not [eval].  If it is, then that's an whole other can of worms.
   * Unfortunately, [call] is too generic.  We happen to have a [call] command in our application already. I wouldn't be surprised if there where collisions in other applications.  It might be necessary to make the command hideously unique, e.g., tcl::call,  callproc, call-by-name, ...

There's my 2 cents worth.
-Brian

> > Regards,> > -- Mathieu> > > On Fri, Dec 30, 2016 at 2:17 AM, Mathieu Lafon <mla...@gmail.com> wrote:>> Hello,>> >> I have updated TIP #457 (Add Support for Named Arguments). The current>> proposal is to add a generic 'call' built-in command with support of>> optional arguments and/or positional arguments.>> >> TIP: http://www.tcl.tk/cgi-bin/tct/tip/457.html>> >> I also have a near-finished implementation of this TIP here:>> https://github.com/mlafon/tcl/tree/457-CALL-CMD>> >> Feedback welcome.>> >> -- Mathieu> > ------------------------------------------------------------------------------> Check out the vibrant tech community on one of the world's most> engaging tech sites, SlashDot.org! http://sdm.link/slashdot> _______________________________________________> Tcl-Core mailing list> Tcl-...@lists.sourceforge.net> https://lists.sourceforge.net/lists/listinfo/tcl-core


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Tcl-Core mailing list
Tcl-...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/tcl-core