| Store | Cart

[TCLCORE] Tracking down a bug

From: Brian Griffin <bria...@mentor.com>
Wed, 21 Nov 2012 17:58:28 -0800
Here's a bug I found, but the real reason for the email is a question about using fossil:  How do I find the check-in comment to explain this change?

First the bug:

---- Release 8.5.13 ----
$ wish8.5
% text .foo
.foo
% set tcl_patchLevel
8.5.13
% .foo tag configure bar -wrap
-wrap {} {} {} {}
% .foo tag configure bar -wrap {}
ambiguous wrap "": must be char, none, word, or 
% exit

---- Release 8.5.8 ----
$ wish8.5 
% set tcl_patchLevel
8.5.8
% text .foo
.foo
% .foo tag configure bar -wrap
-wrap {} {} {} {}
% .foo tag configure bar -wrap {}
% exit

---- Release 8.4.12 ----
$ wish
% set tcl_patchLevel
8.4.12
% text .foo
.foo
% .foo tag configure bar -wrap
-wrap {} {} {} {}
% .foo tag configure bar -wrap {}
% exit

The bogus error that occurs in 8.5.13 is due to this change in tclIndexObj.c:

***************
*** 204,209 ****
--- 202,211 ----
            entryPtr = NEXT_ENTRY(entryPtr, offset), idx++) {
        for (p1 = key, p2 = *entryPtr; *p1 == *p2; p1++, p2++) {
            if (*p1 == '\0') {
+               if (p1 == key) {
+                   /* empty keys never match */
+                   continue;
+               }
                index = idx;
                goto done;
            }

All I can tell locally is the change happened between 8.5.8 and 8.5.13.

How to I query core.tcl.tk to find the checkin that made this change?  I'm hoping the checkin comment will explain why empty keys should never match.

-Brian


------------------------------------------------------------------------------
Monitor your physical, virtual and cloud infrastructure from a single
web console. Get in-depth insight into apps, servers, databases, vmware,
SAP, cloud infrastructure, etc. Download 30-day Free Trial.
Pricing starts from $795 for 25 servers or applications!
http://p.sf.net/sfu/zoho_dev2dev_nov
_______________________________________________
Tcl-Core mailing list
Tcl-...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/tcl-core

Recent Messages in this Thread
Brian Griffin Nov 22, 2012 01:58 am
Richard Hipp Nov 22, 2012 03:04 am
Kevin Kenny Nov 22, 2012 03:17 am
Brian Griffin Nov 22, 2012 04:09 am
Jan Nijtmans Nov 22, 2012 08:24 am
Jan Nijtmans Nov 22, 2012 09:15 am
Richard Hipp Nov 22, 2012 03:18 am
Richard Hipp Nov 22, 2012 03:19 am
Brian Griffin Nov 22, 2012 04:06 am
Donal K. Fellows Nov 22, 2012 10:29 am
Reinhard Max Nov 22, 2012 06:30 am
Alexandre Ferrieux Nov 22, 2012 01:13 pm
Porter, Don Nov 22, 2012 03:58 pm
Messages in this thread