Re: [Python-Dev] libffi embedded in CPython

On 26 March 2015 at 12:40, Zachary Ware <zach...@gmail.com> wrote:
> On Mar 25, 2015 9:28 PM, "Nick Coghlan" <ncog...@gmail.com> wrote:>>>> On 26 March 2015 at 01:57, Steve Dower <Stev...@microsoft.com> wrote:>> > Zachary Ware wrote:>> >> On Mar 25, 2015 4:22 AM, "Paul Moore" <p.f....@gmail.com> wrote:>> >>> On a related note, is there any information available on how the>> >>> "externals" repo is maintained? In particular, should things in there>> >>> be exact copies of upstream, or is it OK to include extra data (in>> >>> this case, the results of running "configure" for the Windows build)?>> >>> It works for me either way, it's just a matter of how the build>> >>> process would be structured and maintained.>> >>>> >> Its not extremely clear how it's "supposed to be" done; look at the>> >> differences>> >> between how we handle OpenSSL and Tcl/Tk, for example. One way or the>> >> other,>> >> though, we will store the configure output so that our build doesn't>> >> depend on>> >> any more than it absolutely has to.>> >>> > It would be nice for at least one other person to know how to do it. I>> > can't see the SVN logs, but I feel like you're the only person who's touched>> > it in a while :)>> >>> > As well as the configure output, we sometimes include very light>> > patching (for example, Tcl/Tk currently has a patch to their makefile to>> > work around a VC14 bug). I'm not sure whether that's considered good>> > practice or not, but I prefer only needing to do it once vs. building it>> > into the build system.>>>> It likely makes sense to try to at least write down the status quo>> regarding the externals repo as a new top level section in the>> Developer's Guide. That way you'll at least have a shared>> understanding of the starting point for any further improvements.>> I'll try to get something thrown together at least by the time I leave> PyCon.  Unfortunately I can't guarantee anything sooner than that.

That sounds plenty soon enough to me - my own list of "I should really
do something about that some day" items stretches back years, as the
issue tracker occasionally reminds me :)

Cheers,
Nick.

-- 
Nick Coghlan   |   ncog...@gmail.com   |   Brisbane, Australia
_______________________________________________
Python-Dev mailing list
Pyth...@python.org
https://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: https://mail.python.org/mailman/options/python-dev/python-dev-ml%40activestate.com