Re: [Python-Dev] libffi embedded in CPython

On Wed, 25 Mar 2015 09:22:01 +0000
Paul Moore <p.f....@gmail.com> wrote:
> On 25 March 2015 at 09:09, Antoine Pitrou <soli...@pitrou.net> wrote:> > I'm not sure we guarantee anything. In any case, it's only a small> > proportion of the kind of crashes you can get by messing the signature.> > Fair point. I guess what I'm asking is, would it be OK to remove the> code that checks for a stack size discrepancy and raises ValueError,> and the tests that verify this behaviour, as part of switching to> using upstream libffi directly?

IMHO yes. Of course it's still a behaviour change, but relying on it
sounds seriously broken.

> On a related note, is there any information available on how the> "externals" repo is maintained? In particular, should things in there> be exact copies of upstream, or is it OK to include extra data (in> this case, the results of running "configure" for the Windows build)?> It works for me either way, it's just a matter of how the build> process would be structured and maintained.

Zachary or Steve could probably answer you on that one.

Regards

Antoine.
_______________________________________________
Python-Dev mailing list
Pyth...@python.org
https://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: https://mail.python.org/mailman/options/python-dev/python-dev-ml%40activestate.com