Re: [Python-Dev] PEP 485 review (isclose())

On 02/27/2015 12:07 PM, Chris Barker wrote:
> Thank you Guido.>> It'll be nice to see this all come to something.>> Thanks to all who contributed to the discussion -- despite this being > a pretty simple function, I learned a lot and far more fully > appreciate the nuance of all of this.>> I'll edit the text as you suggest, and then work on a patch -- I'm > sure I'll have questions for Python-dev when I actually do that, but > I'll get started on my  own and see how far I get.>> -Chris


There's another typo:  The "Large tolerances" section, references a 
"string test".  Perhaps that should be "strong test", but that would 
seem to contradict the sentence which follows.

-- 
Dr. Gary Herron
Department of Computer Science
DigiPen Institute of Technology
(425) 895-4418



>>>>> On Fri, Feb 27, 2015 at 11:38 AM, Guido van Rossum <gui...@python.org > <mailto:gui...@python.org>> wrote:>>     I think it's time to accept PEP 485. I've re-read it once more,>     and it looks like the text is in great shape. (My only>     recommendation would be to update the Abstract to state that we're>     specifically adding math.isclose().)>>     A wording question: "This implementation has a flag that lets the>     user select which relative tolerance test to apply -- this PEP>     does not suggest that that be retained, but rather than the weak>     test be selected." -- I think this was meant to say "... rather>     *that* the weak test be selected", right? (It would be nice if the>     sample implementation defaulted to the choice in the PEP.)>>     However, those are just minor edits, and I hereby approve the PEP.>     Thanks Chris and everyone else for the fruitful discussion (and>     thanks especially to Chris for eventually ending the bikeshedding>     and writing a PEP that explains each of the choices). Congrats!>>     -- >     --Guido van Rossum (python.org/~guido <http://python.org/%7Eguido>)>>>>> -- >> Christopher Barker, Ph.D.> Oceanographer>> Emergency Response Division> NOAA/NOS/OR&R            (206) 526-6959   voice> 7600 Sand Point Way NE   (206) 526-6329   fax> Seattle, WA  98115       (206) 526-6317   main reception>> Chri...@noaa.gov <mailto:Chri...@noaa.gov>>>> _______________________________________________> Python-Dev mailing list> Pyth...@python.org> https://mail.python.org/mailman/listinfo/python-dev> Unsubscribe: https://mail.python.org/mailman/options/python-dev/gherron%40islandtraining.com