Makes sense, thanks. -Ben
On Tue, Jul 22, 2014 at 4:57 PM, Nick Coghlan <ncog...@gmail.com> wrote:
>> On 23 Jul 2014 02:18, "Victor Stinner" <vict...@gmail.com> wrote:>>>> 2014-07-22 17:52 GMT+02:00 Ben Hoyt <benh...@gmail.com>:>> > However, given that we have to support this for listdir() anyway, I>> > think it's worth reconsidering whether scandir()'s directory argument>> > can be an integer FD. Given that listdir() already supports it, it>> > will almost certainly be asked for later anyway for someone who's>> > porting some listdir code that uses an FD. Thoughts, Victor?>>>> Please focus on what was accepted in the PEP. We should first test>> os.scandir(). In a few months, with better feedbacks, we can consider>> extending os.scandir() to support a file descriptor. There are>> different issues which should be discussed and decided to implement it>> (ex: handle the lifetime of the directory file descriptor).>> As Victor suggests, getting the core version working and incorporated first> is a good way to go. Future enhancements (like accepting a file descriptor)> and refactorings (like eliminating the code duplication with listdir) don't> need to (and hence shouldn't) go into the initial patch.>> Cheers,> Nick.>>>>> Victor>>>> _______________________________________________>> Python-Dev mailing list>> Pyth...@python.org>> https://mail.python.org/mailman/listinfo/python-dev>> Unsubscribe:>> https://mail.python.org/mailman/options/python-dev/ncoghlan%40gmail.com
_______________________________________________
Python-Dev mailing list
Pyth...@python.org
https://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: https://mail.python.org/mailman/options/python-dev/python-dev-ml%40activestate.com