Re: ext/XS-APItest/APItest.xs: unused-but-set-variable warnings

On 02/26/2017 01:11 AM, Karl Williamson wrote:
> On 12/28/2016 06:37 PM, James E Keenan wrote:>> In a number of different smoke-test configurations we are getting>> compilation warnings from ext/XS-APItest/APItest.xs>>>> #####>> PItest.c: In function ‘XS_XS__APItest__Magic_test_isASCII_utf8’:>> APItest.xs:5321:24: warning: variable ‘e’ set but not used>> [-Wunused-but-set-variable]>>   const unsigned char * e;>>                         ^>> APItest.c: In function ‘XS_XS__APItest__Magic_test_isASCII_LC_utf8’:>> APItest.xs:5336:24: warning: variable ‘e’ set but not used>> [-Wunused-but-set-variable]>>   const unsigned char * e;>> #####                        ^>>>> #####>> 5318 bool>> 5319 test_isASCII_utf8(unsigned char * p, int type)>> 5320     PREINIT:>> 5321     const unsigned char * e;                 # <-- warning>> 5322     CODE:>> 5323         if (type >= 0) {>> 5324             e = p + UTF8SKIP(p) - type;>> 5325             RETVAL = isASCII_utf8_safe(p, e);>> 5326         }>> 5327         else {>> 5328             RETVAL = isASCII_utf8(p);>> 5329         }>> 5330     OUTPUT:>> 5331         RETVAL>> 5332>> 5333 bool>> 5334 test_isASCII_LC_utf8(unsigned char * p, int type)>> 5335     PREINIT:>> 5336     const unsigned char * e;                # <-- warning>> 5337     CODE:>> 5338         if (type >= 0) {>> 5339             e = p + UTF8SKIP(p) - type;>> 5340             RETVAL = isASCII_LC_utf8_safe(p, e);>> 5341         }>> 5342         else {>> 5343             RETVAL = isASCII_LC_utf8(p);>> 5344         }>> 5345     OUTPUT:>> 5346         RETVAL>> #####>>>> See for example:>>>> http://perl5.test-smoke.org/report/52720 (linux/clang)>>>> http://perl5.test-smoke.org/report/52731 (linux/gcc)>>>> I noticed these because I'm trying to get clang builds to compile>> warnings-free.  Could these be cleaned up?>>>> Thank you very much.>> Jim Keenan>>>> I don't think I got a response from you about whether this has been> fixed or not.>

Yes, fixed by:

commit b3611286c90f556f03af31aa41e42e4fe258f142
Author:     Karl Williamson <k...@cpan.org>
AuthorDate: Wed Dec 28 21:49:06 2016 -0700
Commit:     James E Keenan <jkee...@cpan.org>
CommitDate: Thu Dec 29 08:25:22 2016 -0500

     APItest.xs: Silence compiler warnings

     See: 
http://www.nntp.perl.org/group/perl.perl5.porters/2016/12/msg241877.html

(If that hadn't have worked, I'd have let you know. ;-) )

Thank you very much.
Jim Keenan