[perl #125721] Hash::Util::unlock_hashref_recurse doesn't unlock

# New Ticket Created by  Diab Jerius 
# Please include the string:  [perl #125721]
# in the subject line of all future correspondence about this issue. 
# <URL: https://rt.perl.org/Ticket/Display.html?id=125721 >



This is a bug report for perl from djer...@cpan.org,
generated with the help of perlbug 1.39 running under perl 5.16.3.


-----------------------------------------------------------------
[Please describe your issue here]

Hash::Util::unlock_hashref_recurse doesn't actually unlock the hashref
due to a typo; it calls 

	Internals::SvREADONLY($value,1);

instead of

	Internals::SvREADONLY($value,0);


Here's some sample code:

	use Hash::Util;

	my %hash = ( a => 1 );

	Hash::Util::lock_hashref_recurse( \%hash );
	Hash::Util::unlock_hashref_recurse( \%hash );

	$hash{a} = 3;

and the result:

	% perl bug.pl
	Modification of a read-only value attempted at bug.pl line 8.

While I'm using 5.16.3, this problem seems to exist under 5.22.0 as well.


[Please do not change anything below this line]
-----------------------------------------------------------------
---
Flags:
    category=library
    severity=high
    module=Hash::Util
---
Site configuration information for perl 5.16.3:

Configured by axafbin at Mon Jun 24 14:13:06 EDT 2013.

Summary of my perl5 (revision 5 version 16 subversion 3) configuration:
   
  Platform:
    osname=linux, osvers=3.2.0-4-amd64, archname=x86_64-linux_debian-7-thread-multi
    uname='linux cdptmp 3.2.0-4-amd64 #1 smp debian 3.2.41-2+deb7u2 x86_64 gnulinux '
    config_args='-de -Dprefix=/proj/axaf/ots/pkgs/perl-5.16/x86_64-linux_debian-7 -Uinstallusrbinperl -Dperladmin=none -Dstartperl=#!/usr/bin/env /proj/axaf/bin/perl -Dlocincpth=/proj/axaf/ots/include -Darchname=x86_64-linux_debian-7 -Dusethreads -Dotherlibdirs=/proj/axaf/simul/lib/perl5:/proj/axaf/simul/x86_64-linux_debian-7/lib/perl5 -Dloclibpth=/proj/axaf/ots/x86_64-linux_debian-7/lib -Dglibpth=/lib /usr/lib -Dldflags=-L/proj/axaf/ots/x86_64-linux_debian-7/lib -Wl,-rpath=/proj/axaf/ots/x86_64-linux_debian-7/lib -Duseshrplib'
    hint=recommended, useposix=true, d_sigaction=define
    useithreads=define, usemultiplicity=define
    useperlio=define, d_sfio=undef, uselargefiles=define, usesocks=undef
    use64bitint=define, use64bitall=define, uselongdouble=undef
    usemymalloc=n, bincompat5005=undef
  Compiler:
    cc='cc', ccflags ='-D_REENTRANT -D_GNU_SOURCE -fno-strict-aliasing -pipe -fstack-protector -I/proj/axaf/ots/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64',
    optimize='-O2',
    cppflags='-D_REENTRANT -D_GNU_SOURCE -fno-strict-aliasing -pipe -fstack-protector -I/proj/axaf/ots/include'
    ccversion='', gccversion='4.7.2', gccosandvers=''
    intsize=4, longsize=8, ptrsize=8, doublesize=8, byteorder=12345678
    d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=16
    ivtype='long', ivsize=8, nvtype='double', nvsize=8, Off_t='off_t', lseeksize=8
    alignbytes=8, prototype=define
  Linker and Libraries:
    ld='cc', ldflags ='-L/proj/axaf/ots/x86_64-linux_debian-7/lib -Wl,-rpath=/proj/axaf/ots/x86_64-linux_debian-7/lib -fstack-protector'
    libpth=/proj/axaf/ots/x86_64-linux_debian-7/lib /lib/x86_64-linux-gnu /lib/../lib /usr/lib/x86_64-linux-gnu /usr/lib/../lib /lib /usr/lib
    libs=-lnsl -ldl -lm -lcrypt -lutil -lpthread -lc
    perllibs=-lnsl -ldl -lm -lcrypt -lutil -lpthread -lc
    libc=, so=so, useshrplib=true, libperl=libperl.so
    gnulibc_version='2.13'
  Dynamic Linking:
    dlsrc=dl_dlopen.xs, dlext=so, d_dlsymun=undef, ccdlflags='-Wl,-E -Wl,-rpath,/proj/axaf/ots/pkgs/perl-5.16/x86_64-linux_debian-7/lib/5.16.3/x86_64-linux_debian-7-thread-multi/CORE'
    cccdlflags='-fPIC', lddlflags='-shared -O2 -L/proj/axaf/ots/x86_64-linux_debian-7/lib -fstack-protector'

Locally applied patches:
    

---
@INC for perl 5.16.3:
    /proj/axaf/simul/lib/perl5/x86_64-linux_debian-7-thread-multi
    /proj/axaf/simul/lib/perl5
    /proj/axaf/simul/x86_64-linux_debian-7/lib/perl5/x86_64-linux_debian-7-thread-multi
    /proj/axaf/simul/x86_64-linux_debian-7/lib/perl5
    /proj/axaf/ots/pkgs/perl-5.16/x86_64-linux_debian-7/lib/site_perl/5.16.3/x86_64-linux_debian-7-thread-multi
    /proj/axaf/ots/pkgs/perl-5.16/x86_64-linux_debian-7/lib/site_perl/5.16.3
    /proj/axaf/ots/pkgs/perl-5.16/x86_64-linux_debian-7/lib/5.16.3/x86_64-linux_debian-7-thread-multi
    /proj/axaf/ots/pkgs/perl-5.16/x86_64-linux_debian-7/lib/5.16.3
    /proj/axaf/simul/lib/perl5/x86_64-linux_debian-7-thread-multi
    /proj/axaf/simul/lib/perl5
    /proj/axaf/simul/x86_64-linux_debian-7/lib/perl5/x86_64-linux_debian-7-thread-multi
    /proj/axaf/simul/x86_64-linux_debian-7/lib/perl5
    .

---
Environment for perl 5.16.3:
    HOME=/home/dj
    LANG=en_US.UTF-8
    LANGUAGE (unset)
    LD_LIBRARY_PATH (unset)
    LOGDIR (unset)
    PATH=/home/dj/root/bin:/home/dj/root/bin/hosts:/home/dj/research/bin:/proj/axaf/ots/pkgs/perl-5.16/x86_64-linux_debian-7/bin:/proj/axaf/bin:/proj/axaf/simul/bin:/proj/axaf/simul/x86_64-linux_debian-7/bin:/proj/axaf/ots/x86_64-linux_debian-7/bin:/proj/axaf/ots/x86_64-linux_debian-7.0/bin:/proj/axaf/ots/bin:/usr/local/bin:/usr/sbin:/bin:/usr/bin
    PERL5LIB=/proj/axaf/simul/lib/perl5:/proj/axaf/simul/x86_64-linux_debian-7/lib/perl5
    PERLBREW_BASHRC_VERSION=0.73
    PERLBREW_HOME=/home/dj/.perlbrew
    PERLBREW_ROOT=/home/dj/perl5/perlbrew
    PERL_BADLANG (unset)
    SHELL=/bin/bash