On 21 May 2015 at 17:30, Karl Williamson <pub...@khwilliamson.com> wrote:
> On 05/21/2015 08:08 AM, Ricardo Signes wrote:>>>> * kmx <k...@atlas.cz> [2015-05-21T09:51:04]>>>>>> The bigger trouble IMO is that without the patch the 5.22.0 release will>>> fail to compile with currently widely used combination of gcc + mingw-w64>>> runtime; so rather sooner than later it needs to be addressed anyway.>>>>>> The patch in question is>> http://www.nntp.perl.org/group/perl.perl5.porters/2015/05/msg227969.html>>>> I am inclined to apply it, as its effect seems constrainted to platforms>> we>> know are not passing tests at present.>>>> I would like some +1 or -1 before I do this, as I plan to release RC2>> today.>>>> In the absence of review by anyone who knows what they're talking about, I> can say that the patch looks sane and is seemingly impossible to affect> platforms outside of the targeted ones.
I disagree after having a look at the patch. I'm not in a position to
test anything, but jdb raised a valid suggestion here:
http://www.nntp.perl.org/group/perl.perl5.porters/2015/05/msg227976.html
kmx said that this didn't work. I believe the reason comes down to
what I wrote a couple of message back in this thread (which bulk88
also mentioned in the other thread): HAS_MKSTEMP is being #defined in
win32/config_H.gc, but that only affects the miniperl.exe build.
The main perl.exe/dll build uses a config.h generated from
win32/config.gc, which still has d_mkstemp='undef', so that doesn't
get HAS_MKSTEMP #defined as required when doing things the better way
that jdb suggested.
That could be fixed by conditionally setting d_mkstemp='define' in
win32/config_sh.PL based on the value of $opt{gccversion}.
I will try to get gcc-4.9 and do this later tonight if nobody else
gets there first.