| Store | Cart

[perl #124364] Some version strings in %Module::CoreList::delta contain trailing space and cause warning with version->parse

From: James E Keenan via RT <perl...@perl.org>
Sun, 26 Apr 2015 06:01:59 -0700
On Thu Apr 23 21:45:43 2015, perl...@gmail.com wrote:
> I'd love to get it integrated, but we should probably get at least a> couple> of other people looking at the code first to check its correctness> first.> > On Thu, Apr 23, 2015 at 7:24 PM, Ricardo Signes via RT <> perl...@perl.org> wrote:> > > * perlancar <perl...@perl.org> [2015-04-23T02:15:31]> > > Some version strings in %Module::CoreList::delta contain trailing> > > space> > and> > > cause warning with version->parse, e.g. there is one '1.15 ' which> > > when> > fed> > > to version->parse under warnings:> > >> > > % perl -wE'say version->parse("1.15 ")'> > > Version string '1.15 ' contains invalid data; ignoring: ' ' at -e> > > line> > 1.> > > 1.15> >> > Thanks, I believe I have just fixed all this with b7c1f08.> >> > I see that you probably found this while working on> > Module::CoreList::More,> > which contains, among other things, a "faster is_core."  Is there a> > reason> > we> > shouldn't use your implementation in Module::CoreList?> >> > It seems a shame to leave it in an add-on module that many users> > would> > never> > see.> >> > --> > rjbs> >> >

I've created a project to evaluate Module-CoreList-More at the New York Perl Hackathon, coming up on May 2.

https://github.com/nyperlmongers/nyperlhackathon2015/wiki/Evaluate-Module-CoreList-More

So perhaps we'll get some eyeballs on this there.

Thank you very much.


-- 
James E Keenan (jkee...@cpan.org)

---
via perlbug:  queue: perl5 status: open
https://rt.perl.org/Ticket/Display.html?id=124364

Recent Messages in this Thread
perlancar (via RT) Apr 23, 2015 06:15 am
Ricardo Signes Apr 23, 2015 12:22 pm
Perl Ancar Apr 23, 2015 12:53 pm
James E Keenan via RT Apr 26, 2015 01:01 pm
Graham Knop via RT Apr 27, 2015 02:27 pm
Leon Timmermans May 01, 2015 03:42 pm
Yary via RT May 02, 2015 08:04 pm
Yary via RT May 02, 2015 07:05 pm
Messages in this thread