[perl #122538] perl blead: Update to Test-Simple [patch]

On Wed Oct 22 09:56:57 2014, exod...@gmail.com wrote:
> On Wed Oct 22 09:53:55 2014, exod...@gmail.com wrote:> > We can close this ticket. I submitted a new patch with a re-> > architected Test-Simple that will not have the performance issues of> > this one. I am not sure what ticket number was assigned to my latest> > submission, may not have one yet, sent the email a short time ago.> > > Actually, since I cannot find a *new* ticket from my email, I figure> it might be best just to provide my new patch here, so here it is.

The performance is ok, blead:

All tests successful.
Files=2344, Tests=718918, 204 wallclock secs (68.70 usr  9.84 sys + 433.35 cusr 32.33 csys = 544.22 CPU)
Result: PASS
502.55user 42.18system 3:24.90elapsed 265%CPU (0avgtext+0avgdata 114376maxresident)k
1568inputs+421160outputs (6major+14844787minor)pagefaults 0swaps

vs patched:

Files=2394, Tests=720189, 213 wallclock secs (71.58 usr 12.05 sys + 470.17 cusr 39.18 csys = 592.98 CPU)
Result: PASS
542.92user 51.27system 3:34.56elapsed 276%CPU (0avgtext+0avgdata 134276maxresident)k
352inputs+421688outputs (0major+17219051minor)pagefaults 0swaps

which is an 8% increase in CPU usage.  Run with TEST_JOBS=6.

Unfortunately there's a change of behaviour WRT $TODO.

Before the patch, setting $TODO to the empty string (and possibly other false values) would not treat the test as TODO, but with the patch such cases are treated as TODO, so several tests are treated TODO passed:

../ext/XS-APItest/t/call_checker.t                               (Wstat: 0 Tests: 76 Failed: 0)
  TODO passed:   1
../ext/Devel-Peek/t/Peek.t                                       (Wstat: 0 Tests: 134 Failed: 0)
  TODO passed:   24, 32, 38, 54, 70, 72, 74, 76

I could update perl's tests to supply undef instead, but this change in behaviour may be a problem for CPAN distributions too.

git still complains about whitespace errors.

Tony

---
via perlbug:  queue: perl5 status: open
https://rt.perl.org/Ticket/Display.html?id=122538