[perl #122282] [PATCH] Open3.pm:spawn_with_handles remove alot of duplicate

On Sun Jul 20 18:09:29 2014, tonyc wrote:
> On Sun Jul 20 09:08:53 2014, bulk88 wrote:> > On Sat Jul 19 20:14:41 2014, jkeenan wrote:> > > And since we're now doing a lot of work on spawn_with_handles(), I> > > figured we should get rid of the hard tabs as indents.> > >> > > All of which led to a new patch, attached.  Does it look okay?> >> > I'd rather keep $fd declared once. It is more efficient than taking> > the lexical in and out of scope. I dont have much of a comment on the> > reindenting. Some git diff tools don't ignore whitespace (gitweb).> > I prefer Jim's, but it's a good illustration of why whitespace changes> should be done separately from non-whitespace changes.> > Tony

In an effort to give everybody some of what they want, I re-drew the patches as two patches instead of one squashed one.  (Of course, I thereby run the risk that porting/cmp_version.t will fail.)

Of course, this guarantees that everyone will be unhappy.

See commits:
Dragan: fe49d2ed6f822f90ed54ed40f03f306e831b8503
Keenan: c1e7a0a2cac6d665e90d28a4b81db40e72276749

Marking ticket resolved.

Thank you very much.
Jim Keenan


---
via perlbug:  queue: perl5 status: open
https://rt.perl.org/Ticket/Display.html?id=122282