| Store | Cart

Re: [perl #121721] Bleadperl breaks TOKUHIROM/Test-SharedFork-0.24 on Windows

From: Dave Mitchell <dav...@iabyn.com>
Thu, 24 Apr 2014 16:36:13 +0100
On Wed, Apr 23, 2014 at 04:29:48PM -0700, bulk88 via RT wrote:
> No idea why the patch works or if its appropriate but it stopped the> crash. Without a rational of why these werent null before. Or why it> didn't crash before. This shouldn't be applied. I got no crashed on AP> 5.10 and VC 5.12 and SP Win32 strawberry-perl 5.18.0.1. It might be> because the bug isn't there in older Perls, or by chance the uninit> memory was filled with NULL so no crash.

It might be better to just skip duping savearray and argarray
unless CxHASARGS(cx) is true. In fact looking at Perl_cx_dup(), I see it
already does that check for argarray; I guess it just needs extending to
handle savearray too.

As to why it didn't previously fail, I don't know. New CX stacks have
been being poisoned for many years, so getting 0xababab.. is nothing new.
I guess someone with Windows access needs to run a debugger on 5.18.0 or
whatever and see what savearray is set to.


-- 
The crew of the Enterprise encounter an alien life form which is
surprisingly neither humanoid nor made from pure energy.
    -- Things That Never Happen in "Star Trek" #22

Recent Messages in this Thread
Alexandr Ciornii (via RT) Apr 23, 2014 08:55 pm
bulk88 via RT Apr 23, 2014 10:52 pm
bulk88 via RT Apr 23, 2014 11:29 pm
Dave Mitchell Apr 24, 2014 03:36 pm
bulk88 via RT Apr 25, 2014 07:56 am
Dave Mitchell Apr 25, 2014 11:57 am
Alexandr Ciornii via RT Apr 24, 2014 12:08 am
bulk88 via RT Apr 26, 2014 10:14 pm
bulk88 via RT Apr 29, 2014 03:51 pm
Ricardo SIGNES via RT May 06, 2014 02:38 pm
Tony Cook via RT May 07, 2014 12:47 am
bulk88 via RT Apr 27, 2014 03:11 am
bulk88 via RT Apr 27, 2014 04:14 am
bulk88 via RT Apr 27, 2014 04:20 am
bulk88 via RT Apr 27, 2014 05:31 pm
bulk88 via RT Apr 27, 2014 06:20 pm
bulk88 via RT Apr 27, 2014 06:21 pm
bulk88 via RT Apr 27, 2014 08:17 pm
bulk88 via RT Apr 28, 2014 05:40 am
bulk88 via RT Apr 25, 2014 07:18 am
Tony Cook via RT May 06, 2014 06:49 am
Messages in this thread